Skip to content

fix(web): Limits account labels stay readable with five or more accounts - #36137

Open
craigcossairt wants to merge 4 commits into
pingdotgg:mainfrom
craigcossairt:fix/limits-account-labels
Open

craigcossairt wants to merge 4 commits into
pingdotgg:mainfrom
craigcossairt:fix/limits-account-labels

Conversation

@craigcossairt

Copy link
Copy Markdown

Problem

With five accounts on one provider, Usage → Limits cuts off every account name in the bar ("Pe…", "Devel…", "Develo…"), so the segments look the same and each one has to be hovered to identify it. This happens even in a 2560px wide window.

Fixes #36134.

Change

Two parts of the same fix:

  • The bar picks its layout per account. PoolBar switched to the labeled layout with @2xl/pool, which looks only at the bar's width. Its container is now sized to one account's share of the bar, so the query asks whether a segment has 11rem for its label. When it does not, the bar falls back to the numbered rows it already uses on narrow screens, which show full names. Bars with up to three accounts keep the old 42rem breakpoint exactly.
  • Limits uses the modal's width. The Limits list was held to max-w-5xl inside the 80rem modal, so a five-account bar could never reach the width its labels need, however wide the window. WorkspacePageContainer gets a full width that Limits uses. The other Usage views stay on wide.

docs/user/usage.md said the numbered rows appear "on narrow screens"; it now says they appear when a bar is too narrow to label every account.

Scope

Bug fix. The bug is shown in #36134.

#32534 edits lines next to these in UsageLimitsPooled.tsx. Whichever lands second needs a small rebase, and I will do it if that is this one.

Verification

I hit this with five Claude accounts on a 2560×1032 window.

To check the fix I rendered the Limits view inside AppRouteModal in Chromium through the repo's browser test harness, on made-up accounts ("Personal", "Developer 1" to "Developer 4"), and captured it on main and on this branch:

  • 2560×1030, five accounts. Before: every name is cut off. After: each segment shows its full name, percentage and reset time. One exception remains: in the Session row, the segment that also shows a banked reset credit shortens "Personal" to "Perso…".
  • 1080×1680, five accounts. Before: every name is cut off. After: the bar is too narrow for five labels, so it shows numbered segments with a row per account below. Each of those cards is about 100px taller as a result.
  • 1600×1000, three accounts. Labeled segments before and after. The list is wider.
  • 1600×1000, four accounts and 700×1000, five accounts. Same layout before and after (labels and numbered rows respectively).
Before After
2560×1030, five accounts before after
1080×1680, five accounts before after
1600×1000, three accounts before after

vp run check:changed passed format, typecheck, the test beside the change, and the React compiler check. Lint passes on the changed files. Knip could not run in my checkout because the mobile and marketing dependencies are not installed.

No test added: this is a layout bug and the captures are the proof.

Not checked: the packaged desktop app. The screenshots come from the component harness, not a running server. The accounts in them are made up because my real Limits page shows account emails.

Claude Fable 5.2 in Claude Code, run from T3 Code.

🤖 Generated with Claude Code

The Limits bar chose its labeled layout from the bar's width alone, so a pool
of five accounts got segments too narrow for their names and every name was
cut off. The layout now asks whether one account's share of the bar has room
for a label, and falls back to the numbered rows when it does not. Limits also
uses the full width of the Usage modal, so a wide window labels more accounts.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T11:19:56.777309Z f305ca3 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions github-actions Bot added vouch:unvouched Author is not yet trusted in the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Nov 13, 2026
@macroscopeapp

macroscopeapp Bot commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at f305ca3

Macroscope's review found this PR approvable — Limits gains more horizontal space and switches to numbered account legends when individual labels would be cramped. The changes are presentation-only, leaving usage data and limit behavior unchanged.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Pooled Usage Limits bars scale account columns and switch segment and zero-spend-cap layouts at a container-width breakpoint. The usage documentation now describes numbered rows based on whether the bar can label every account.

Changes: Usage Limits layout

Layer / File(s) Summary
Pooled bar column sizing
apps/web/src/components/usage/UsageLimitsPooled.tsx
PoolBar scales its grid and account container widths using the number of columns and a minimum share value.
Pooled bar labels and sizing
apps/web/src/components/usage/UsageLimitsPooled.tsx, docs/user/usage.md
Segment, legend, and zero-spend-cap layouts switch at the @min-[11rem]/pool breakpoint. The documentation says numbered rows appear when the bar is too narrow to label every account.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Low

Possibly related PRs

  • pingdotgg/t3code#37487: Changes how pooled account identity appears below quota bars at narrow widths, overlapping with this PR’s account-label layout.
  • pingdotgg/t3code#30072: Changes label presentation for the same pooled account bars.

Suggested labels: bugfix

Suggested reviewers: juliusmarminge, yash-singh1

Merge Risk: Minimal · up to 1efd8

This change makes account labels in Usage Limits stay readable when a provider has five or more accounts, and falls back to numbered rows when labels would not fit. No concrete merge-blocking risk was found; the risk is limited to visual layout.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: Limits account labels stay readable when a provider has five or more accounts. The raw summary shows the PoolBar layout threshold change and the Limits width change th…
Description check Passed The description follows the template. It has Problem, Change, Scope, and Verification sections, and each is filled in with specific content. The problem is stated with a reproduction environment and t…
Linked Issues check Passed [#36134] The two causes named in the issue are addressed at the reviewed head. (1) The labeled layout no longer depends on @2xl/pool. The segment, legend, and zero-spend-cap rows switch on @min-[11rem…
Out of Scope Changes check Passed The changes connect to #36134. UsageLimitsPooled.tsx changes the labeled-layout query and the bar sizing, which are the causes the issue names. WorkspacePageContainer.tsx adds a "full" width that Usag…
Full details: Title check

Explanation

The title names the main change: Limits account labels stay readable when a provider has five or more accounts. The raw summary shows the PoolBar layout threshold change and the Limits width change that serve this goal. The title uses the conventional commit form the template asks for. The title is 72 characters, which is within a normal length.

Full details: Description check

Explanation

The description follows the template. It has Problem, Change, Scope, and Verification sections, and each is filled in with specific content. The problem is stated with a reproduction environment and the linked issue #36134. The change explains both parts of the fix and why each is needed. Scope says this is a bug fix and links the bug. Verification gives focused manual captures, before and after screenshots, the checks run, and what was not checked. The model and harness line is present. The description has no gaps that block review.

Full details: Linked Issues check

Explanation

[#36134] The two causes named in the issue are addressed at the reviewed head. (1) The labeled layout no longer depends on @2xl/pool. The segment, legend, and zero-spend-cap rows switch on @min-[11rem]/pool. The head file read confirms this for the segment triggers in apps/web/src/components/usage/UsageLimitsPooled.tsx. The PoolBar container sizing (100/share% of the bar, where share = max(columns, 42/11)) comes from the whole-PR summary; the read was truncated before that section, so it was not confirmed directly. Bars with up to three accounts keep a 42rem minimum width, which matches the issue's statement that three or fewer accounts are fine. (2) The Limits list uses the new WorkspacePageContainer "full" width, so it is no longer capped at max-w-5xl. When a segment lacks 11rem, the existing numbered rows (index badges and legend rows) show full names, which is the fallback the issue requests. The PR description reports captures at 2560×1030 with five accounts (labels shown) and 1080×1680 (numbered rows). One residual truncation remains: "Personal" shortens to "Perso…" in the Session segment that also shows a reset credit. The segments stay distinguishable, so the expected behavior is met. No automated test was added; the issue does not request one. Limitation: the incremental diffs since the previous reviewed heads (f305ca3, 88984bb) could not be read because diff metadata exceeded the buffer and changed blobs were missing. The conclusion rests on the whole-PR summary and the head file excerpt, which agree with the prior assessment.

Full details: Out of Scope Changes check

Explanation

The changes connect to #36134. UsageLimitsPooled.tsx changes the labeled-layout query and the bar sizing, which are the causes the issue names. WorkspacePageContainer.tsx adds a "full" width that UsagePage uses only for the limits metric, which addresses the max-w-5xl cause. The other Usage views stay on "wide". docs/user/usage.md changes the numbered-row condition to match the new behavior; the whole-PR summary supports this. The PR description notes that #32534 edits adjacent lines in UsageLimitsPooled.tsx; this is a merge coordination concern, not out-of-scope work. Limitation: the incremental diffs since the previous reviewed heads could not be read, so changes in those commits are verified only through the whole-PR summary and the head file excerpt.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 88984bb and 1efd860.

Files selected for processing: 2

  • apps/web/src/components/usage/UsageLimitsPooled.tsx
  • docs/user/usage.md
Files skipped from review as they are similar to previous changes: 1

  • docs/user/usage.md

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

@juliusmarminge juliusmarminge added the takeover:in-progress A takeover lead is working on this PR label Nov 13, 2026
juliusmarminge and others added 2 commits November 13, 2026 11:24
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The label clipping is fixed by the per-account breakpoint alone: a bar
too narrow to label every account falls back to the numbered rows, which
show full names. Widening the Limits page is a separate layout change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@juliusmarminge juliusmarminge added takeover:needs-julius Takeover done; route gate says Julius decides and removed takeover:in-progress A takeover lead is working on this PR labels Nov 13, 2026
devuterian added a commit to devuterian/t3code-korean that referenced this pull request Nov 16, 2026
…nts (pingdotgg#36137)

Cherry-picked from upstream pingdotgg#36137 (open PR) into the Korean fork.
devuterian added a commit to devuterian/t3code-korean that referenced this pull request Nov 16, 2026
pingdotgg#36137 moved the pool container query to one account's share of the bar. The zero-spend-cap cell, added upstream after that PR's base, sits in the same row and still used the old whole-bar breakpoint, so it would switch height and labels apart from its neighbours.
@github-actions

Copy link
Copy Markdown
Contributor

This PR conflicts with main. Rebase it or merge main into it. If it still conflicts after 7 days with no activity, it will be closed automatically.

See the conflict window.

@github-actions github-actions Bot added the needs-rebase Conflicts with its base branch. Closes after 7 days with no activity. label Nov 19, 2026
@juliusmarminge juliusmarminge added takeover:in-progress A takeover lead is working on this PR and removed takeover:needs-julius Takeover done; route gate says Julius decides labels Nov 20, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@juliusmarminge

Copy link
Copy Markdown
Member

The automated pipeline stopped on this pull request and will not merge it:

the fix is written and reviewed, but proving it needs something no worker has:

  • Permanent blocker: five authenticated first-party Claude OAuth accounts with usage limits are required for the reported reproduction; first-party Claude OAuth usage, limit, and renewal flows are explicitly unavailable on every VM. Both the 2560×1030 readable-label layout and the 1080×1680 numbered-segment/account-row layout remain unverified.

It stays open for a person to finish or close.

@juliusmarminge juliusmarminge added takeover:blocked Takeover blocked; reason in the PR body and removed takeover:in-progress A takeover lead is working on this PR labels Nov 21, 2026
@github-actions github-actions Bot removed the needs-rebase Conflicts with its base branch. Closes after 7 days with no activity. label Nov 22, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). takeover:blocked Takeover blocked; reason in the PR body vouch:unvouched Author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Usage Limits cuts off every account name when a provider has five accounts, even in a wide window

2 participants